-
-
Notifications
You must be signed in to change notification settings - Fork 252
refactor: migrate assets controllers messenger #6745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mikesposito/messenger/polling-controllers
Are you sure you want to change the base?
refactor: migrate assets controllers messenger #6745
Conversation
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
6a27d5a to
6e80728
Compare
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that Cursor noticed.
| AllEvents, | ||
| RootMessenger | ||
| >({ | ||
| namespace: controllerName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it does seem that we need a parent option here.
…sito/messenger/assets-controllers
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…sito/messenger/assets-controllers
…ntrollers' into mikesposito/messenger/assets-controllers * origin/mikesposito/messenger/polling-controllers: Update ESLint warning threshold Fix changelog mistakes from recent merges Update changelogs following branch update Update messagingSystem references to messenger
Explanation
This PR migrates all remaining assets controllers to
@metamask/messengerinstead of@metamask/base-controller. This is part of a larger effort to migrate all controllers to use@metamask/messenger.References
Checklist
Note
Migrates remaining assets controllers and tests from base-controller messenger to @metamask/messenger, updating metadata APIs and messaging calls.
MultichainAssetsController,MultichainBalancesController,NftDetectionController,RatesController, andTokenSearchDiscoveryDataController(and relatedtypes) to@metamask/messenger.RestrictedMessengerwithMessenger; update calls frommessagingSystem.*tomessenger.*(publish,subscribe,call).@metamask/base-controller/next; adoptStateMetadataandincludeInDebugSnapshotin controller metadata.MessengerActions,MessengerEvents), and messenger construction (root/delegated namespaces) in tests.includeInDebugSnapshot; keep polling events (pollingStarted/pollingStopped) publishing via new messenger.delegateAPIs; updatederiveStateFromMetadatacalls toincludeInDebugSnapshot.Messenger(adds PR references).Written by Cursor Bugbot for commit 65a9c08. This will update automatically on new commits. Configure here.